Bug 1638022 - Phabbugz should not try to set needs-review when the revision is closed...

diff --git a/extensions/PhabBugz/lib/Feed.pm b/extensions/PhabBugz/lib/Feed.pm
index baa887677de074dec7273fa40052bc7e06557013..a3290fbbe6b27a091e0d89d8b6161d8713389bb2 100644 (file)
--- a/extensions/PhabBugz/lib/Feed.pm
+++ b/extensions/PhabBugz/lib/Feed.pm
@@ -520,12 +520,14 @@ sub process_revision_change {
   }
 
   # Set status to request-review if revision is new and
-  # in draft state and not changes-planned
+  # in draft state and not changes-planned, closed, or abandoned.
   if ($is_new
       && $revision->status ne 'changes-planned'
+      && $revision->status ne 'closed'
+      && $revision->status ne 'abandoned'
       && ($revision->is_draft && !$revision->hold_as_draft))
   {
-    INFO("Moving from draft to needs-review");
+    INFO('Moving from draft to needs-review');
     $revision->set_status('request-review');
   }