lua/output: access luastate within lock

Fixes Coverity issue:

CID 1648445: (#1 of 1): Data race condition (MISSING_LOCK)
4. missing_lock: Accessing td->lua_ctx->luastate without holding lock
LogLuaCtx_.m. Elsewhere, LogLuaCtx_.luastate is written to with
LogLuaCtx_.m held 41 out of 41 times.

diff --git a/src/output-lua.c b/src/output-lua.c
index 3e1edaef3291f97a905783f0eb7b8ce04ae81c7c..6f63fb1a706f8a32fdc683433d301d35b58e8829 100644 (file)
--- a/src/output-lua.c
+++ b/src/output-lua.c
@@ -126,9 +126,8 @@ static int LuaStreamingLogger(ThreadVars *tv, void *thread_data, const Flow *f,
     }
 
     LogLuaThreadCtx *td = (LogLuaThreadCtx *)thread_data;
-    lua_State *luastate = td->lua_ctx->luastate;
-
     SCMutexLock(&td->lua_ctx->m);
+    lua_State *luastate = td->lua_ctx->luastate;
 
     LuaStateSetThreadVars(luastate, tv);
     if (flags & OUTPUT_STREAMING_FLAG_TRANSACTION)