patch 9.0.2007: Vim9: covariant parameter types allowed

Problem:  Vim9: covariant parameter types allowed when assigning
          functions
Solution: Enforce invariant type check for arguments and return value
          when assigning a funcref

closes: #13299
closes: #13305

Signed-off-by: Christian Brabandt <cb@256bit.org>
Co-authored-by: Yegappan Lakshmanan <yegappan@yahoo.com>

diff --git a/src/testdir/test_vim9_class.vim b/src/testdir/test_vim9_class.vim
index c911206c9f20a2fcdc4b2c01e8d93286cf7c5ad9..ce7d5f7faaf1a9305f46ab264c662f51b911bfcc 100644 (file)
--- a/src/testdir/test_vim9_class.vim
+++ b/src/testdir/test_vim9_class.vim
@@ -7154,4 +7154,41 @@ def Test_recursive_class_method_call()
   v9.CheckSourceSuccess(lines)
 enddef
 
+" Test for checking the argument types and the return type when assigning a
+" funcref to make sure the invariant class type is used.
+def Test_funcref_argtype_returntype_check()
+  var lines =<< trim END
+    vim9script
+    class A
+    endclass
+    class B extends A
+    endclass
+
+    def Foo(p: B): B
+      return B.new()
+    enddef
+
+    var Bar: func(A): A = Foo
+  END
+  v9.CheckSourceFailure(lines, 'E1012: Type mismatch; expected func(object<A>): object<A> but got func(object<B>): object<B>', 11)
+
+  lines =<< trim END
+    vim9script
+    class A
+    endclass
+    class B extends A
+    endclass
+
+    def Foo(p: B): B
+      return B.new()
+    enddef
+
+    def Baz()
+      var Bar: func(A): A = Foo
+    enddef
+    Baz()
+  END
+  v9.CheckSourceFailure(lines, 'E1012: Type mismatch; expected func(object<A>): object<A> but got func(object<B>): object<B>', 1)
+enddef
+
 " vim: ts=8 sw=2 sts=2 expandtab tw=80 fdm=marker

diff --git a/src/version.c b/src/version.c
index 08c34e1894f4d66c7f268cdeb9232a1cc938ff69..489ecb871e37dda045d771c53e8a8e7e1e2a1f81 100644 (file)
--- a/src/version.c
+++ b/src/version.c
@@ -704,6 +704,8 @@ static char *(features[]) =
 
 static int included_patches[] =
 {   /* Add new patch number below this line */
+/**/
+    2007,
 /**/
     2006,
 /**/

diff --git a/src/vim9type.c b/src/vim9type.c
index de1033c2e90ccc0a62f1b600873b797273ade7e2..338aee14a731c028dc03b423b2e2ee66d27445cd 100644 (file)
--- a/src/vim9type.c
+++ b/src/vim9type.c
@@ -874,8 +874,7 @@ check_type_maybe(
                {
                    where_T  func_where = where;
 
-                   if (where.wt_kind == WT_METHOD)
-                       func_where.wt_kind = WT_METHOD_RETURN;
+                   func_where.wt_kind = WT_METHOD_RETURN;
                    ret = check_type_maybe(expected->tt_member,
                                            actual->tt_member, FALSE,
                                            func_where);
@@ -898,8 +897,7 @@ check_type_maybe(
                                               && i < actual->tt_argcount; ++i)
                {
                    where_T  func_where = where;
-                   if (where.wt_kind == WT_METHOD)
-                       func_where.wt_kind = WT_METHOD_ARG;
+                   func_where.wt_kind = WT_METHOD_ARG;
 
                    // Allow for using "any" argument type, lambda's have them.
                    if (actual->tt_args[i] != &t_any && check_type(