]> git.ipfire.org Git - thirdparty/samba.git/commitdiff
s4:dsdb: Remove unnecessary MIN()
authorJo Sutton <josutton@catalyst.net.nz>
Thu, 18 Jan 2024 02:16:36 +0000 (15:16 +1300)
committerMartin Schwenke <martins@samba.org>
Tue, 2 Jul 2024 03:39:35 +0000 (03:39 +0000)
Since we have ensured that val->length >= sizeof(hash->hash),
MIN(val->length, sizeof(hash->hash)) will here always be equal to
sizeof(hash->hash).

Signed-off-by: Jo Sutton <josutton@catalyst.net.nz>
Reviewed-by: Martin Schwenke <martin@meltin.net>
source4/dsdb/common/util.c

index 868ce43271994db480733d23d8d234ff8f8bfbf3..757133eb277a211b22dd59701df1554d851d06e4 100644 (file)
@@ -539,7 +539,7 @@ struct samr_Password *samdb_result_hash(TALLOC_CTX *mem_ctx, const struct ldb_me
                        return NULL;
                }
                talloc_keep_secret(hash);
-               memcpy(hash->hash, val->data, MIN(val->length, sizeof(hash->hash)));
+               memcpy(hash->hash, val->data, sizeof(hash->hash));
        }
        return hash;
 }