]> git.ipfire.org Git - thirdparty/suricata.git/commitdiff
pgsql: rename 'dummy' response variables
authorJuliana Fajardini <jufajardini@oisf.net>
Sat, 10 May 2025 19:35:08 +0000 (16:35 -0300)
committerJuliana Fajardini <jufajardini@oisf.net>
Wed, 4 Jun 2025 18:21:32 +0000 (15:21 -0300)
While this could be considered minor, they were not just bad, but
misleading names, as the variables weren't really `dummy` responses,
but consolidating several messages.

rust/src/pgsql/pgsql.rs

index 52300dc80aaba74d314c44e3177b133cd1cddda5..7dcbe6497de3dcff38e5fb37d52bc0b866fc38dc 100644 (file)
@@ -638,14 +638,14 @@ impl PgsqlState {
                                 && tx.get_row_cnt() > 0
                             {
                                 // let's summarize the info from the data_rows in one response
-                                let dummy_resp = PgsqlBEMessage::ConsolidatedDataRow(
+                                let consolidated_data_row = PgsqlBEMessage::ConsolidatedDataRow(
                                     ConsolidatedDataRowPacket {
                                         identifier: b'D',
                                         row_cnt: tx.get_row_cnt(),
                                         data_size: tx.data_size, // total byte count of all data_row messages combined
                                     },
                                 );
-                                tx.responses.push(dummy_resp);
+                                tx.responses.push(consolidated_data_row);
                                 tx.responses.push(response);
                                 // reset values
                                 tx.data_row_cnt = 0;
@@ -654,14 +654,14 @@ impl PgsqlState {
                                 tx.incr_row_cnt();
                             } else if state == PgsqlStateProgress::CopyDoneReceived && tx.get_row_cnt() > 0 {
                                 // let's summarize the info from the data_rows in one response
-                                let dummy_resp = PgsqlBEMessage::ConsolidatedCopyDataOut(
+                                let consolidated_copy_data = PgsqlBEMessage::ConsolidatedCopyDataOut(
                                     ConsolidatedDataRowPacket {
                                         identifier: b'd',
                                         row_cnt: tx.get_row_cnt(),
                                         data_size: tx.data_size, // total byte count of all data_row messages combined
                                     },
                                 );
-                                tx.responses.push(dummy_resp);
+                                tx.responses.push(consolidated_copy_data);
                                 tx.responses.push(response);
                                 // reset values
                                 tx.data_row_cnt = 0;