Don't load module.la from current directory by default.

* libltdl/ltdl.c (try_dlopen): Do not attempt to load an
unqualified module.la file from the current directory (by
default) since doing so is insecure and is not compliant with
the documentation.
* tests/testsuite.at: Qualify access to module.la file in
current directory so that test passes.

diff --git a/ChangeLog b/ChangeLog
index f4c2c407041ffbf94cb196bdf3e8e43a289593e0..6dc22980d71080d5ef89bc9dfd1c594dc406571d 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,13 @@
+2009-11-14  Bob Friesenhahn  <bfriesen@simple.dallas.tx.us>
+
+       Don't load module.la from current directory by default.
+       * libltdl/ltdl.c (try_dlopen): Do not attempt to load an
+       unqualified module.la file from the current directory (by
+       default) since doing so is insecure and is not compliant with
+       the documentation.
+       * tests/testsuite.at: Qualify access to module.la file in
+       current directory so that test passes.
+
 2009-11-14  Peter O'Gorman  <peter@pogma.com>
 
        Only use preopen loader to load preopened archives

diff --git a/libltdl/ltdl.c b/libltdl/ltdl.c
index ddb9c28dad973b567a18ef8f55385a4ee340cd78..24ee13f1d6d8c4f1039a84ea049716a3bce41416 100644 (file)
--- a/libltdl/ltdl.c
+++ b/libltdl/ltdl.c
@@ -1346,7 +1346,7 @@ try_dlopen (lt_dlhandle *phandle, const char *filename, const char *ext,
            }
 #endif
        }
-      if (!file)
+      else
        {
          file = fopen (attempt, LT_READTEXT_MODE);
        }

diff --git a/tests/testsuite.at b/tests/testsuite.at
index e9226eee14cf8014e0e32a817837f3341751c7a1..34f7f216aec472b50aa05263c4d9e1062032d93b 100644 (file)
--- a/tests/testsuite.at
+++ b/tests/testsuite.at
@@ -336,9 +336,9 @@ main ()
     return 1;
   }
 
-  module = lt_dlopen("module.la");
+  module = lt_dlopen("./module.la");
   if (!module) {
-    fprintf (stderr, "error dlopening module.la: %s\n", lt_dlerror());
+    fprintf (stderr, "error dlopening ./module.la: %s\n", lt_dlerror());
     goto finish;
   }