Do not include cleanups.h from common-defs.h

Most code doesn't use cleanups any more, so remove the include of
cleanups.h from common-defs.h, and then only include that file where
it is truly needed.

Approved-By: Simon Marchi <simon.marchi@efficios.com>

diff --git a/gdb/compile/compile.c b/gdb/compile/compile.c
index 229e155ef2e810720ea13817cb8c6099113783d7..5d81ec12b7149f9f9d92d4e5dba76e413106bb77 100644 (file)
--- a/gdb/compile/compile.c
+++ b/gdb/compile/compile.c
@@ -45,6 +45,7 @@
 #include "gdbsupport/pathstuff.h"
 #include "gdbsupport/scoped_ignore_signal.h"
 #include "gdbsupport/buildargv.h"
+#include "gdbsupport/cleanups.h"
 
 /* Hold "compile" commands.  */
 

diff --git a/gdb/debuginfod-support.c b/gdb/debuginfod-support.c
index 8f28fd538712f129725068827d8479013422fb79..e99c13bc569e516f1c4d10571bf04c383f70e28a 100644 (file)
--- a/gdb/debuginfod-support.c
+++ b/gdb/debuginfod-support.c
@@ -18,6 +18,7 @@
 
 #include "diagnostics.h"
 #include <errno.h>
+#include "gdbsupport/cleanups.h"
 #include "gdbsupport/scoped_fd.h"
 #include "debuginfod-support.h"
 #include <optional>

diff --git a/gdb/run-on-main-thread.c b/gdb/run-on-main-thread.c
index 30b0928778ddae5c5545a0c804cbf9bbadf602dd..bf53163b6b717bc7101619da15ce45810952284d 100644 (file)
--- a/gdb/run-on-main-thread.c
+++ b/gdb/run-on-main-thread.c
@@ -22,6 +22,7 @@
 #include <thread>
 #include <mutex>
 #endif
+#include "gdbsupport/cleanups.h"
 #include "gdbsupport/event-loop.h"
 
 /* The serial event used when posting runnables.  */

diff --git a/gdb/top.c b/gdb/top.c
index 72d19530070ea0c7cec0647cf643bb0556e3a37b..b097683e6138102fe543dfe5d68dda73895f1124 100644 (file)
--- a/gdb/top.c
+++ b/gdb/top.c
@@ -34,6 +34,7 @@
 #include "value.h"
 #include "language.h"
 #include "terminal.h"
+#include "gdbsupport/cleanups.h"
 #include "gdbsupport/job-control.h"
 #include "annotate.h"
 #include "completer.h"

diff --git a/gdb/value.c b/gdb/value.c
index 5574642bc33a2a3c3afae37aef685ea64a7845a4..82d9a86e372aea4a50d0b612996cf8ebecc39058 100644 (file)
--- a/gdb/value.c
+++ b/gdb/value.c
@@ -45,6 +45,7 @@
 #include <utility>
 #include <vector>
 #include "completer.h"
+#include "gdbsupport/cleanups.h"
 #include "gdbsupport/selftest.h"
 #include "gdbsupport/array-view.h"
 #include "cli/cli-style.h"

diff --git a/gdbsupport/common-defs.h b/gdbsupport/common-defs.h
index cfdefe19ce0f61644853b291e4de88e92b87f6ee..8d7e2a9353c198adbcb63f5473634702a3c4e563 100644 (file)
--- a/gdbsupport/common-defs.h
+++ b/gdbsupport/common-defs.h
@@ -216,7 +216,6 @@
 #include "errors.h"
 #include "print-utils.h"
 #include "common-debug.h"
-#include "cleanups.h"
 #include "common-exceptions.h"
 #include "gdbsupport/poison.h"