cmdline:burn: '-U' does not imply secrets without '%'

We return true from this function when a secret has been erased,
and were accidentally treating  as if it had secrets.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=15671

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Jo Sutton <josutton@catalyst.net.nz>

diff --git a/lib/cmdline/cmdline.c b/lib/cmdline/cmdline.c
index 93d59d4f9d34ff93c891e9e91fd0a02ea2e2c959..8d5dc36e42b0404e12e1322addf25987a56c7d86 100644 (file)
--- a/lib/cmdline/cmdline.c
+++ b/lib/cmdline/cmdline.c
@@ -182,9 +182,11 @@ bool samba_cmdline_burn(int argc, char *argv[])
 
                        if (is_user) {
                                q = strchr_m(p, '%');
-                               if (q != NULL) {
-                                       p = q;
+                               if (q == NULL) {
+                                       /* -U without '%' has no secret */
+                                       continue;
                                }
+                               p = q;
                        } else {
                                p += ulen;
                        }