]> git.ipfire.org Git - thirdparty/starlette.git/commitdiff
Remove mypy skip flags (#2497)
authorScirlat Danut <danut.scirlat@gmail.com>
Fri, 9 Feb 2024 21:39:42 +0000 (23:39 +0200)
committerGitHub <noreply@github.com>
Fri, 9 Feb 2024 21:39:42 +0000 (21:39 +0000)
* Remove flags

* Apply suggestions from code review

* Remove mypy overrides

---------

Co-authored-by: Scirlat Danut <scirlatdanut@scirlats-mini.lan>
Co-authored-by: Marcelo Trylesinski <marcelotryle@gmail.com>
pyproject.toml
scripts/check

index 48562e714885eaf5117f4fee6be310b3f5b0c644..3cf7c0d407e2cd534c123e3d97ec1060affd8809 100644 (file)
@@ -66,14 +66,6 @@ python_version = "3.8"
 module = "starlette.testclient.*"
 implicit_optional = true
 
-# TODO: Uncomment the following configuration when
-# https://github.com/python/mypy/issues/10045 is solved. In the meantime,
-# we are calling `mypy tests` directly. Check `scripts/check` for more info.
-# [[tool.mypy.overrides]]
-# module = "tests.*"
-# disallow_untyped_defs = false
-# check_untyped_defs = true
-
 [tool.pytest.ini_options]
 addopts = "-rxXs --strict-config --strict-markers"
 xfail_strict = true
index 7f169e3bcd5bfcdadf92c04a989e4819205a5695..3e8f057846ffa0846b847886cf05940f3bb7f796 100755 (executable)
@@ -12,6 +12,5 @@ set -x
 ${PREFIX}ruff format --check --diff $SOURCE_FILES
 # TODO: Use `[[tool.mypy.overrides]]` on the `pyproject.toml` when the mypy issue is solved:
 # github.com/python/mypy/issues/10045. Check github.com/encode/starlette/pull/2180 for more info.
-${PREFIX}mypy starlette
-${PREFIX}mypy tests --disable-error-code no-untyped-def --disable-error-code no-untyped-call
+${PREFIX}mypy $SOURCE_FILES
 ${PREFIX}ruff check $SOURCE_FILES