]> git.ipfire.org Git - thirdparty/suricata.git/commitdiff
http2: do not set file flags for global txs
authorPhilippe Antoine <pantoine@oisf.net>
Tue, 15 Apr 2025 10:38:34 +0000 (12:38 +0200)
committerVictor Julien <vjulien@oisf.net>
Thu, 3 Jul 2025 10:16:22 +0000 (12:16 +0200)
Global txs means here txs with stream id 0, used for connection control
messages.

rust/src/http2/http2.rs

index 5a711e7c7c8d429c193e6abf7637eb93f2d9810a..af6e22f69cf9c49169d81e8f5a9883d717b5f377 100644 (file)
@@ -721,10 +721,7 @@ impl HTTP2State {
         self.tx_id += 1;
         tx.tx_id = self.tx_id;
         tx.state = HTTP2TransactionState::HTTP2StateGlobal;
-        tx.tx_data.update_file_flags(self.state_data.file_flags);
-        // TODO can this tx hold files?
-        tx.tx_data.file_tx = STREAM_TOSERVER | STREAM_TOCLIENT; // might hold files in both directions
-        tx.update_file_flags(tx.tx_data.file_flags);
+        // a global tx (stream id 0) does not hold files cf RFC 9113 section 5.1.1
         self.transactions.push_back(tx);
         return self.transactions.back_mut().unwrap();
     }