]> git.ipfire.org Git - ipfire-2.x.git/commitdiff
firewall.cgi: Remove some left-over debugging code core195
authorMichael Tremer <michael.tremer@ipfire.org>
Wed, 25 Jun 2025 14:22:32 +0000 (15:22 +0100)
committerMichael Tremer <michael.tremer@ipfire.org>
Wed, 25 Jun 2025 14:24:52 +0000 (15:24 +0100)
This code prevented that any firewall rules could have been created due
to the WUI always assuming that there would be some error.

Fixes: #13860 - Error message when creating a firewall rule with a subnet for src
Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>
html/cgi-bin/firewall.cgi

index 855be095d02c991705f1b3e4fb118e7297a93e3f..5f1eac09e6612a7ea9db8eb39c4a2b91d0ee67f8 100644 (file)
@@ -876,12 +876,6 @@ sub checkrule
                                        $hint.=$Lang::tr{'fwdfw hint ip2'}." Source: $networkip1/$scidr Target: $networkip2/$tcidr<br>";
                                }
                }else{
-                       $errormessage .= $sip;
-                       $errormessage .= $scidr;
-
-                       $errormessage .= $tip;
-                       $errormessage .= $tcidr;
-
                        if ( &General::IpInSubnet($networkip2,$sip,&General::iporsubtodec($scidr)) ){
                        $errormessage.=$Lang::tr{'fwdfw err samesub'} . $fwdfwsettings{'grp1'} .$fwdfwsettings{$fwdfwsettings{'grp1'}} . $fwdfwsettings{'grp2'} . $fwdfwsettings{$fwdfwsettings{'grp2'}};
                        }