]> git.ipfire.org Git - thirdparty/pdns.git/commitdiff
dnsdist: Clarify that if the call failed we still own the DOHUnit 11103/head
authorRemi Gacogne <remi.gacogne@powerdns.com>
Wed, 15 Dec 2021 11:19:11 +0000 (12:19 +0100)
committerRemi Gacogne <remi.gacogne@powerdns.com>
Wed, 15 Dec 2021 13:21:51 +0000 (14:21 +0100)
(cherry picked from commit 9d53151a282e9a98f75d28e8fcbff7901a07b592)

pdns/dnsdistdist/doh.cc

index e6f6594677e945c216b615c153457a6786d80b77..c0dfba3e596261d2c58e6fe45af9a113cc5dcee3 100644 (file)
@@ -726,7 +726,8 @@ static void processDOHQuery(DOHUnitUniquePtr&& du)
 
     int fd = pickBackendSocketForSending(du->downstream);
     try {
-      /* you can't touch du after this line, because it might already have been freed */
+      /* you can't touch du after this line, unless the call returned a non-negative value,
+         because it might already have been freed */
       ssize_t ret = udpClientSendRequestToBackend(du->downstream, fd, du->query);
 
       if (ret < 0) {