]> git.ipfire.org Git - thirdparty/openwrt.git/commitdiff
kernel: usb: fix dependencies for kmod-cdns3 and kmod-cdns 19246/head
authorThomas Richard <thomas.richard@bootlin.com>
Fri, 27 Jun 2025 14:08:42 +0000 (16:08 +0200)
committerHauke Mehrtens <hauke@hauke-m.de>
Fri, 8 Aug 2025 16:06:51 +0000 (18:06 +0200)
The cdns3 driver can be built without usb host mode support. Fix
dependencies to handle the case it is built with only gadget support.

Signed-off-by: Thomas Richard <thomas.richard@bootlin.com>
Link: https://github.com/openwrt/openwrt/pull/19246
Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de>
package/kernel/linux/modules/usb.mk

index af9346775ef56e47b245baeabae4b1b85332366f..8bf070a047175769beae5113e735373a8892eed4 100644 (file)
@@ -470,13 +470,15 @@ $(eval $(call KernelPackage,usb-dwc2-pci))
 
 
 define KernelPackage/usb-cdns
+  SUBMENU:=$(USB_MENU)
   TITLE:=Cadence USB USB controller driver
-  DEPENDS:=+USB_GADGET_SUPPORT:kmod-usb-gadget +kmod-usb-roles
+  DEPENDS:=+USB_GADGET_SUPPORT:kmod-usb-gadget \
+          +USB_SUPPORT:kmod-usb-core \
+          +kmod-usb-roles
   KCONFIG:= \
        CONFIG_USB_CDNS_SUPPORT
   FILES:= $(LINUX_DIR)/drivers/usb/cdns3/cdns-usb-common.ko
   AUTOLOAD:=$(call AutoLoad,50,cdns-usb-common,1)
-  $(call AddDepends/usb)
 endef
 
 define KernelPackage/usb-cdns/description
@@ -488,15 +490,15 @@ $(eval $(call KernelPackage,usb-cdns))
 
 
 define KernelPackage/usb-cdns3
+  SUBMENU:=$(USB_MENU)
   TITLE:=Cadence USB3 USB controller driver
   DEPENDS:=+kmod-usb-cdns
   KCONFIG:= \
        CONFIG_USB_CDNS3 \
-       CONFIG_USB_CDNS3_GADGET=y \
-       CONFIG_USB_CDNS3_HOST=y
+       CONFIG_USB_CDNS3_GADGET=$(if $(CONFIG_USB_GADGET_SUPPORT),y,n) \
+       CONFIG_USB_CDNS3_HOST=$(if $(CONFIG_USB_SUPPORT),y,n)
   FILES:= $(LINUX_DIR)/drivers/usb/cdns3/cdns3.ko
   AUTOLOAD:=$(call AutoLoad,54,cdns3,1)
-  $(call AddDepends/usb)
 endef
 
 define KernelPackage/usb-cdns3/description