]> git.ipfire.org Git - thirdparty/libsolv.git/commitdiff
decision.c: void function should not return anything 588/head
authorChristoph Grüninger <foss@grueninger.de>
Tue, 13 May 2025 17:11:35 +0000 (19:11 +0200)
committerChristoph Grüninger <foss@grueninger.de>
Tue, 13 May 2025 17:12:54 +0000 (19:12 +0200)
Do not call to solver_get_proof as part of return statement

Found by GCC ("ISO C forbids ‘return’ with expression, in
function returning void", pedantic).

src/decision.c

index ec9da99c2f6f8878934ffc8932be0120d2718e56..353b80c8aebbf8b6878dfe08230b5aa4f3466364 100644 (file)
@@ -737,7 +737,10 @@ solver_get_decisionlist(Solver *solv, Id id, int flags, Queue *decisionlistq)
   Pool *pool = solv->pool;
   Map dm;
   if ((flags & SOLVER_DECISIONLIST_TYPEMASK) != SOLVER_DECISIONLIST_SOLVABLE)
-    return solver_get_proof(solv, id, flags, decisionlistq);
+  {
+    solver_get_proof(solv, id, flags, decisionlistq);
+    return;
+  }
   map_init(&dm, pool->nsolvables);
   MAPSET(&dm, id);
   getdecisionlist(solv, &dm, flags, decisionlistq);