From: Martin Schwenke <mschwenke@ddn.com>
Date: Sun, 1 Jun 2025 01:05:31 +0000 (+1000)
Subject: ctdb-tcp: Fix CID 1291643 - Resource leak (RESOURCE_LEAK)
X-Git-Tag: tdb-1.4.14~78
X-Git-Url: http://git.ipfire.org/gitweb/gitweb.cgi?a=commitdiff_plain;h=014a1bd981accc8aad0a81375b032ba33c25569d;p=thirdparty%2Fsamba.git

ctdb-tcp: Fix CID 1291643 - Resource leak (RESOURCE_LEAK)

Signed-off-by: Martin Schwenke <mschwenke@ddn.com>
Reviewed-by: Anoop C S <anoopcs@samba.org>
---

diff --git a/ctdb/tcp/tcp_connect.c b/ctdb/tcp/tcp_connect.c
index d69c196dbe4..e508e9aba1a 100644
--- a/ctdb/tcp/tcp_connect.c
+++ b/ctdb/tcp/tcp_connect.c
@@ -578,6 +578,7 @@ static int ctdb_tcp_listen_automatic(struct ctdb_context *ctdb)
 	}
 
 	TALLOC_FREE(ips_ctx);
+	close(lock_fd);
 
 	if (i == ctdb->num_nodes) {
 		D_ERR("Unable to bind to any node address - giving up\n");