From: Tobias Brunner <tobias@strongswan.org>
Date: Mon, 19 Jul 2021 15:46:58 +0000 (+0200)
Subject: key-exchange: Warn about costly operations in set_public_key()
X-Git-Tag: 5.9.7dr2~1^2~8
X-Git-Url: http://git.ipfire.org/gitweb/gitweb.cgi?a=commitdiff_plain;h=0351b5af3bebf5331743343203f4c857796630cb;p=thirdparty%2Fstrongswan.git

key-exchange: Warn about costly operations in set_public_key()
---

diff --git a/src/libstrongswan/crypto/key_exchange.h b/src/libstrongswan/crypto/key_exchange.h
index b55ed558ed..70d6d49938 100644
--- a/src/libstrongswan/crypto/key_exchange.h
+++ b/src/libstrongswan/crypto/key_exchange.h
@@ -105,6 +105,10 @@ struct key_exchange_t {
 	/**
 	 * Sets the public key from the peer.
 	 *
+	 * @note This operation should be relatively quick. Costly public key
+	 * validation operations or key derivation should be implemented in
+	 * get_shared_secret().
+	 *
 	 * @param value		public key of peer
 	 * @return			TRUE if other public key verified and set
 	 */