From: Tobias Oetiker <tobi@oetiker.ch>
Date: Tue, 12 Oct 2021 08:35:43 +0000 (+0200)
Subject: be more agressive in extracting bad characters from cgi variables
X-Git-Tag: v1.8.0~17^2~1
X-Git-Url: http://git.ipfire.org/gitweb/gitweb.cgi?a=commitdiff_plain;h=03b61bbb694a74c61843397388b37e429bdbf01e;p=thirdparty%2Frrdtool-1.x.git

be more agressive in extracting bad characters from cgi variables
---

diff --git a/src/rrd_cgi.c b/src/rrd_cgi.c
index e58069f6..36a79976 100644
--- a/src/rrd_cgi.c
+++ b/src/rrd_cgi.c
@@ -792,7 +792,8 @@ static char *rrdstrip(
 
     p = buf;
     while (*p) {
-        if (*p == '<' || *p == '>') {
+        if (*p == '<' || *p == '>' ||
+            *p == '&' || *p < ' ' || *p > '\'' || *p == '"') {
             *p = '_';
         }
         p++;
@@ -919,7 +920,7 @@ static char *drawgraph(
             break;
     if (i == argc) {
         args[argc++] = "--imginfo";
-        args[argc++] = "<IMG SRC=\"./%s\" WIDTH=\"%lu\" HEIGHT=\"%lu\">";
+        args[argc++] = "<img src=\"./%s\" width=\"%lu\" height=\"%lu\" />";
     }
     calfree();
     if (rrd_graph