From: Sami Kerola <kerolasa@iki.fi>
Date: Sat, 16 Apr 2016 16:43:01 +0000 (+0100)
Subject: script: avoid trying fclose(NULL)
X-Git-Tag: v2.28.1~53
X-Git-Url: http://git.ipfire.org/gitweb/gitweb.cgi?a=commitdiff_plain;h=06aa13858b6a0f8b6f534c25c26eb594cb30dd15;p=thirdparty%2Futil-linux.git

script: avoid trying fclose(NULL)

Here is a one-liner to reproduce the issue.

$ mkdir example && cd example && chmod 0500 . && script
Script started, file is typescript
script: cannot open typescript: Permission denied
                                                 Script done, file is typescript
Segmentation fault (core dumped)

Addresses: https://bugs.launchpad.net/bugs/1537518
Signed-off-by: Sami Kerola <kerolasa@iki.fi>
---

diff --git a/term-utils/script.c b/term-utils/script.c
index 119974230f..ff8320c6c1 100644
--- a/term-utils/script.c
+++ b/term-utils/script.c
@@ -205,7 +205,8 @@ static void __attribute__((__noreturn__)) done(struct script_control *ctl)
 
 	if (ctl->timingfp)
 		fclose(ctl->timingfp);
-	fclose(ctl->typescriptfp);
+	if (ctl->typescriptfp)
+		fclose(ctl->typescriptfp);
 
 	if (ctl->rc_wanted) {
 		if (WIFSIGNALED(ctl->childstatus))