From: gkinkie@gmail.com <kinkie@squid-cache.org>
Date: Sun, 18 Sep 2022 23:58:37 +0000 (+0000)
Subject: Do not check unused RECV_ARG_TYPE (#1146)
X-Git-Tag: SQUID_5_8~11
X-Git-Url: http://git.ipfire.org/gitweb/gitweb.cgi?a=commitdiff_plain;h=0d7da2a30ad35abb678bf023fe707eb316cbb215;p=thirdparty%2Fsquid.git

Do not check unused RECV_ARG_TYPE (#1146)

The check and corresponding defined preprocessor value
are not used anywhere in the code; remove the check
---

diff --git a/acinclude/os-deps.m4 b/acinclude/os-deps.m4
index e089505249..7aaf761c4b 100644
--- a/acinclude/os-deps.m4
+++ b/acinclude/os-deps.m4
@@ -812,33 +812,6 @@ AC_DEFUN([SQUID_CHECK_FUNCTIONAL_CPU_PROFILER],[
   )
 ])
 
-dnl check whether recv takes a char* or void* as a second argument
-AC_DEFUN([SQUID_CHECK_RECV_ARG_TYPE],[
-  AC_CACHE_CHECK([whether recv takes a pointer to void or char as second argument],
-         squid_cv_recv_second_arg_type, [
-                 AC_COMPILE_IFELSE([AC_LANG_PROGRAM([[
-#include <sys/types.h>
-#if HAVE_SYS_SOCKET_H
-#include <sys/socket.h>
-#endif
-#if HAVE_WINSOCK2_H
-#include <winsock2.h>
-#elif HAVE_WINSOCK_H
-#include <winsock.h>
-#endif
-int main (int argc, char ** argv) {
-       void *buf;
-  recv(0,buf,0,0);
-}
-]])],[squid_cv_recv_second_arg_type=void],
-     [squid_cv_recv_second_arg_type=char])
-  AC_MSG_RESULT($squid_cv_recv_second_arg_type*)
-  ])
-  AC_DEFINE_UNQUOTED(RECV_ARG_TYPE,$squid_cv_recv_second_arg_type,
-    [Base type of the second argument to recv(2)])
-])
-
-
 dnl check whether Solaris has broken IPFilter headers (Solaris 10 at least does)
 AC_DEFUN([SQUID_CHECK_BROKEN_SOLARIS_IPFILTER],[
   if test "x$squid_cv_broken_ipfilter_minor_t" = "x"; then
diff --git a/configure.ac b/configure.ac
index d91943a663..e0ab493fc0 100644
--- a/configure.ac
+++ b/configure.ac
@@ -3733,7 +3733,6 @@ SQUID_DETECT_UDP_RECV_BUFSIZE
 SQUID_DETECT_TCP_SND_BUFSIZE
 SQUID_DETECT_TCP_RECV_BUFSIZE
 
-SQUID_CHECK_RECV_ARG_TYPE
 SQUID_CHECK_NEED_SYS_ERRLIST
 SQUID_CHECK_MAXPATHLEN