From: Tom Tromey <tom@tromey.com>
Date: Thu, 2 Mar 2023 22:08:42 +0000 (-0700)
Subject: Remove NR_DOMAINS
X-Git-Tag: gdb-15-branchpoint~1120
X-Git-Url: http://git.ipfire.org/gitweb/gitweb.cgi?a=commitdiff_plain;h=0ff2d66b1f1f3125ff59a97539b97a61bc0d6bf3;p=thirdparty%2Fbinutils-gdb.git

Remove NR_DOMAINS

NR_DOMAINS is only used for a static assert, but we no longer need it
now.  If we add too many constants to this enum, GCC will warn about
the bitfield overflow:

    error: ‘symbol::m_domain’ is too small to hold all values of ‘enum domain_enum’
---

diff --git a/gdb/symtab.h b/gdb/symtab.h
index 729c003f1c1..6b5b087e99a 100644
--- a/gdb/symtab.h
+++ b/gdb/symtab.h
@@ -922,15 +922,11 @@ enum domain_enum
   /* Fortran common blocks.  Their naming must be separate from VAR_DOMAIN.
      They also always use LOC_COMMON_BLOCK.  */
   COMMON_BLOCK_DOMAIN,
-
-  /* This must remain last.  */
-  NR_DOMAINS
 };
 
 /* The number of bits in a symbol used to represent the domain.  */
 
 #define SYMBOL_DOMAIN_BITS 3
-static_assert (NR_DOMAINS <= (1 << SYMBOL_DOMAIN_BITS));
 
 extern const char *domain_name (domain_enum);