From: Daniel Espinosa <esodan@gmail.com>
Date: Sun, 2 Jan 2022 23:11:37 +0000 (-0600)
Subject: Assigment: use context if available to avoid Report static access
X-Git-Url: http://git.ipfire.org/gitweb/gitweb.cgi?a=commitdiff_plain;h=12509e37fcca0cd5b65dcd55c0137c989d1e04c6;p=thirdparty%2Fvala.git

Assigment: use context if available to avoid Report static access
---

diff --git a/vala/valaassignment.vala b/vala/valaassignment.vala
index 672303256..936b8cec5 100644
--- a/vala/valaassignment.vala
+++ b/vala/valaassignment.vala
@@ -306,7 +306,7 @@ public class Vala.Assignment : Expression {
 				unowned ArrayType? variable_array_type = variable.variable_type as ArrayType;
 				if (variable_array_type != null && variable_array_type.inline_allocated
 				    && right is ArrayCreationExpression && ((ArrayCreationExpression) right).initializer_list == null) {
-					Report.warning (source_reference, "Inline allocated arrays don't require an explicit instantiation");
+					context.report.log_warning (source_reference, "Inline allocated arrays don't require an explicit instantiation");
 					((Block) parent_node.parent_node).replace_statement ((Statement) parent_node, new EmptyStatement (source_reference));
 					return true;
 				}
@@ -323,7 +323,7 @@ public class Vala.Assignment : Expression {
 				} else if (left.value_type is EnumValueType && right.value_type is IntegerType
 				    && (!(right is IntegerLiteral) || ((IntegerLiteral) right).value != "0")) {
 					//FIXME This will have to be an error in the future?
-					Report.notice (source_reference, "Assignment: Unsafe conversion from `%s' to `%s'", right.value_type.to_string (), left.value_type.to_string ());
+					context.report.log_notice (source_reference, "Assignment: Unsafe conversion from `%s' to `%s'", right.value_type.to_string (), left.value_type.to_string ());
 				}
 
 				if (!(ma.symbol_reference is Property)) {
@@ -346,17 +346,17 @@ public class Vala.Assignment : Expression {
 			unowned MemberAccess? right_ma = right as MemberAccess;
 			if (right_ma != null && ma.symbol_reference == right_ma.symbol_reference) {
 				if (ma.symbol_reference is LocalVariable || ma.symbol_reference is Parameter) {
-					Report.warning (source_reference, "Assignment to same variable");
+					context.report.log_warning (source_reference, "Assignment to same variable");
 				} else if (ma.symbol_reference is Field) {
 					unowned Field f = (Field) ma.symbol_reference;
 					if (f.binding == MemberBinding.STATIC) {
-						Report.warning (source_reference, "Assignment to same variable");
+						context.report.log_warning (source_reference, "Assignment to same variable");
 					} else {
 						unowned MemberAccess? ma_inner = ma.inner as MemberAccess;
 						unowned MemberAccess? right_ma_inner = right_ma.inner as MemberAccess;
 						if (ma_inner != null && ma_inner.member_name == "this" && ma_inner.inner == null &&
 						    right_ma_inner != null && right_ma_inner.member_name == "this" && right_ma_inner.inner == null) {
-							Report.warning (source_reference, "Assignment to same variable");
+							context.report.log_warning (source_reference, "Assignment to same variable");
 						}
 					}
 				}