From: Mike Brady <4265913+mikebrady@users.noreply.github.com> Date: Thu, 31 Oct 2024 14:17:29 +0000 (+0000) Subject: Remove a misleading comment. X-Git-Tag: 4.3.5^2~12 X-Git-Url: http://git.ipfire.org/gitweb/gitweb.cgi?a=commitdiff_plain;h=1488bf0a34da7199cc7b7e9b527821c180cd58be;p=thirdparty%2Fshairport-sync.git Remove a misleading comment. --- diff --git a/audio_jack.c b/audio_jack.c index 0a00900e..c1e92104 100644 --- a/audio_jack.c +++ b/audio_jack.c @@ -88,12 +88,7 @@ soxr_io_spec_t io_spec; #endif static inline sample_t sample_conv(short sample) { - // It sounds correct, but I don't understand it. - // Zero int needs to be zero float. Check. - // Plus 32767 int is 1.0. Check. - // Minus 32767 int is -0.99997. And here my brain shuts down. - // In my head, it should be 1.0, and we should tolerate an overflow - // at minus 32768. But I'm sure there's a textbook explanation somewhere. + // signed 16-bit int to float return ((sample < 0) ? (-1.0 * sample / SHRT_MIN) : (1.0 * sample / SHRT_MAX)); }