From: Mike Bayer <mike_mp@zzzcomputing.com>
Date: Wed, 5 Dec 2007 22:04:27 +0000 (+0000)
Subject: - ordering of cols in pks_by_table and cols_by_table is significant;
X-Git-Tag: rel_0_4_2~104
X-Git-Url: http://git.ipfire.org/gitweb/gitweb.cgi?a=commitdiff_plain;h=1c65cb025a1186b1e6a7597ca36b0f44bbc9dea2;p=thirdparty%2Fsqlalchemy%2Fsqlalchemy.git

- ordering of cols in pks_by_table and cols_by_table is significant;
particularly for pks_by_table the ordering is expected to match the ordering
of pk columns in the table for usage in query.get() as well as identity key
generation
---

diff --git a/lib/sqlalchemy/orm/mapper.py b/lib/sqlalchemy/orm/mapper.py
index f7bf3f5d9d..18c639af06 100644
--- a/lib/sqlalchemy/orm/mapper.py
+++ b/lib/sqlalchemy/orm/mapper.py
@@ -408,12 +408,15 @@ class Mapper(object):
         for t in util.Set(self.tables + [self.mapped_table]):
             self._all_tables.add(t)
             if t.primary_key and pk_cols.issuperset(t.primary_key):
-                self._pks_by_table[t] = util.Set(t.primary_key).intersection(pk_cols)
-            self._cols_by_table[t] = util.Set(t.c).intersection(all_cols)
+                # ordering is important since it determines the ordering of mapper.primary_key (and therefore query.get())
+                self._pks_by_table[t] = util.OrderedSet(t.primary_key).intersection(pk_cols)
+            self._cols_by_table[t] = util.OrderedSet(t.c).intersection(all_cols)
             
         if self.primary_key_argument:
             for k in self.primary_key_argument:
-                self._pks_by_table.setdefault(k.table, util.Set()).add(k)
+                if k.table not in self._pks_by_table:
+                    self._pks_by_table[k.table] = util.OrderedSet()
+                self._pks_by_table[k.table].add(k)
                 
         if len(self._pks_by_table[self.mapped_table]) == 0:
             raise exceptions.ArgumentError("Could not assemble any primary key columns for mapped table '%s'" % (self.mapped_table.name))