From: dtucker@openbsd.org <dtucker@openbsd.org>
Date: Wed, 30 Jul 2025 10:17:13 +0000 (+0000)
Subject: upstream: Plug leak in case where sigp is passed as NULL. Coverity CID
X-Git-Url: http://git.ipfire.org/gitweb/gitweb.cgi?a=commitdiff_plain;h=284abbed9a8d815b1ec5e96aff885d77e26537e7;p=thirdparty%2Fopenssh-portable.git

upstream: Plug leak in case where sigp is passed as NULL. Coverity CID

483725, ok djm@

OpenBSD-Commit-ID: 47cf7b399c84e102b670b9f97ab6926c9a7256b5
---

diff --git a/ssh-pkcs11-client.c b/ssh-pkcs11-client.c
index 64b8f4c1c..8be0d8aec 100644
--- a/ssh-pkcs11-client.c
+++ b/ssh-pkcs11-client.c
@@ -1,4 +1,4 @@
-/* $OpenBSD: ssh-pkcs11-client.c,v 1.23 2025/07/25 11:50:45 dtucker Exp $ */
+/* $OpenBSD: ssh-pkcs11-client.c,v 1.24 2025/07/30 10:17:13 dtucker Exp $ */
 /*
  * Copyright (c) 2010 Markus Friedl.  All rights reserved.
  * Copyright (c) 2014 Pedro Martelletto. All rights reserved.
@@ -278,6 +278,7 @@ pkcs11_sign(struct sshkey *key,
 	ret = 0;
 
  fail:
+	free(signature);
 	sshbuf_free(msg);
 	return ret;
 }