From: Nick Porter <nick@portercomputing.co.uk>
Date: Mon, 21 Jul 2025 14:23:55 +0000 (+0100)
Subject: No need to call fr_network_listen_delete here
X-Git-Url: http://git.ipfire.org/gitweb/gitweb.cgi?a=commitdiff_plain;h=2975ca3f0d2290d2be9c35893961b1e0653614e3;p=thirdparty%2Ffreeradius-server.git

No need to call fr_network_listen_delete here

It only looks up the socket and calls fr_network_socket_dead, but the
socket likely has already been removed from the tree of sockets by the
socket talloc destructor - which is what is calling mod_close
---

diff --git a/src/lib/io/master.c b/src/lib/io/master.c
index 509aadb801..3c371937c8 100644
--- a/src/lib/io/master.c
+++ b/src/lib/io/master.c
@@ -2800,13 +2800,6 @@ static int mod_close(fr_listen_t *li)
 	}
 	pthread_mutex_unlock(&connection->parent->mutex);
 
-	/*
-	 *	Clean up listener
-	 */
-	if (unlikely(fr_network_listen_delete(connection->nr, child) < 0)) {
-		PERROR("Failed to delete connection %s", connection->name);
-	}
-
 	talloc_free(connection->mi);
 
 	return 0;