From: Frédéric Buclin <LpSolit@gmail.com>
Date: Thu, 7 Jan 2016 20:45:23 +0000 (+0100)
Subject: Bug 402039: Exporting CSV from chart.cgi doesn't set mimetype, content_disposition... 
X-Git-Tag: release-5.0.3~32
X-Git-Url: http://git.ipfire.org/gitweb/gitweb.cgi?a=commitdiff_plain;h=2fdc142ef1119b9fc2741181ee4386c64c3c1677;p=thirdparty%2Fbugzilla.git

Bug 402039: Exporting CSV from chart.cgi doesn't set mimetype, content_disposition, or filename
r/a=dkl
---

diff --git a/chart.cgi b/chart.cgi
index 00b0b8ee5d..c1bafa1175 100755
--- a/chart.cgi
+++ b/chart.cgi
@@ -305,16 +305,15 @@ sub plot {
     $vars->{'chart'} = new Bugzilla::Chart($cgi);
 
     my $format = $template->get_format("reports/chart", "", scalar($cgi->param('ctype')));
+    $format->{'ctype'} = 'text/html' if $cgi->param('debug');
 
-    # Debugging PNGs is a pain; we need to be able to see the error messages
-    if ($cgi->param('debug')) {
-        print $cgi->header();
-        $vars->{'chart'}->dump();
-    }
-
+    $cgi->set_dated_content_disp('inline', 'chart', $format->{extension});
     print $cgi->header($format->{'ctype'});
     disable_utf8() if ($format->{'ctype'} =~ /^image\//);
 
+    # Debugging PNGs is a pain; we need to be able to see the error messages
+    $vars->{'chart'}->dump() if $cgi->param('debug');
+
     $template->process($format->{'template'}, $vars)
       || ThrowTemplateError($template->error());
 }