From: nikitasol <nikita@handrich.es>
Date: Thu, 30 Jul 2020 12:10:40 +0000 (+0200)
Subject: Correctly add horizontal divider styles
X-Git-Tag: v2.4.0~4^2~3^2
X-Git-Url: http://git.ipfire.org/gitweb/gitweb.cgi?a=commitdiff_plain;h=47c58238a9723b3ad443bfd3008fe4b8274e6a24;p=thirdparty%2Ffoundation%2Ffoundation-emails.git

Correctly add horizontal divider styles

1. As per Inky the <hr> should be added as <h-line> - fixed in docs
2. margin is not a list and just needs 1 value which should be applied to th which inky adds (not td)
---

diff --git a/docs/pages/typography.md b/docs/pages/typography.md
index b9514a5b..e49be32b 100644
--- a/docs/pages/typography.md
+++ b/docs/pages/typography.md
@@ -69,5 +69,5 @@ Links are very standard, and the color is preset to the Foundation primary color
 Use dividers to define thematic breaks between paragraphs or sections of your email.
 
 ```html
-<hr/>
+<h-line></h-line>
 ```
diff --git a/scss/components/_typography.scss b/scss/components/_typography.scss
index 55731ef0..3c0ccd34 100755
--- a/scss/components/_typography.scss
+++ b/scss/components/_typography.scss
@@ -163,7 +163,7 @@ $remove-ios-blue: true !default;
 /// @param {String} $width  - Width of divider
 /// @param {String} $border - Shorthand border style for divider
 /// @param {String} $margin - Margin above and below divider
-@mixin h-line($align: $hr-align, $width: $hr-width, $border: $hr-border, $margin: nth($hr-margin, 1)) {
+@mixin h-line($align: $hr-align, $width: $hr-width, $border: $hr-border, $margin: $hr-margin) {
   @at-root {
     td.columns & table,
     td.column  & table,
@@ -190,7 +190,7 @@ $remove-ios-blue: true !default;
       Margin: 0;
     }
 
-      td {
+      th {
         width: $width;
         height: 0;
         padding-top: $margin;