From: Junio C Hamano <gitster@pobox.com>
Date: Thu, 10 Oct 2024 21:22:24 +0000 (-0700)
Subject: Merge branch 'ps/reftable-alloc-failures'
X-Git-Tag: v2.48.0-rc0~130
X-Git-Url: http://git.ipfire.org/gitweb/gitweb.cgi?a=commitdiff_plain;h=5575c713c2a398f4723c544fb732c44b8e1d5e45;p=thirdparty%2Fgit.git

Merge branch 'ps/reftable-alloc-failures'

The reftable library is now prepared to expect that the memory
allocation function given to it may fail to allocate and to deal
with such an error.

* ps/reftable-alloc-failures: (26 commits)
  reftable/basics: fix segfault when growing `names` array fails
  reftable/basics: ban standard allocator functions
  reftable: introduce `REFTABLE_FREE_AND_NULL()`
  reftable: fix calls to free(3P)
  reftable: handle trivial allocation failures
  reftable/tree: handle allocation failures
  reftable/pq: handle allocation failures when adding entries
  reftable/block: handle allocation failures
  reftable/blocksource: handle allocation failures
  reftable/iter: handle allocation failures when creating indexed table iter
  reftable/stack: handle allocation failures in auto compaction
  reftable/stack: handle allocation failures in `stack_compact_range()`
  reftable/stack: handle allocation failures in `reftable_new_stack()`
  reftable/stack: handle allocation failures on reload
  reftable/reader: handle allocation failures in `reader_init_iter()`
  reftable/reader: handle allocation failures for unindexed reader
  reftable/merged: handle allocation failures in `merged_table_init_iter()`
  reftable/writer: handle allocation failures in `reftable_new_writer()`
  reftable/writer: handle allocation failures in `writer_index_hash()`
  reftable/record: handle allocation failures when decoding records
  ...
---

5575c713c2a398f4723c544fb732c44b8e1d5e45
diff --cc reftable/stack.c
index 84cf37a2ad,63976e5cea..7e617c2591
--- a/reftable/stack.c
+++ b/reftable/stack.c
@@@ -749,9 -790,13 +798,13 @@@ int reftable_stack_new_addition(struct 
  {
  	int err = 0;
  	struct reftable_addition empty = REFTABLE_ADDITION_INIT;
+ 
  	REFTABLE_CALLOC_ARRAY(*dest, 1);
+ 	if (!*dest)
+ 		return REFTABLE_OUT_OF_MEMORY_ERROR;
+ 
  	**dest = empty;
 -	err = reftable_stack_init_addition(*dest, st);
 +	err = reftable_stack_init_addition(*dest, st, flags);
  	if (err) {
  		reftable_free(*dest);
  		*dest = NULL;