From: Darrick J. Wong Date: Wed, 24 Feb 2021 01:20:57 +0000 (-0500) Subject: xfs_repair: enable bigtime upgrade via repair X-Git-Tag: v5.11.0-rc1~3 X-Git-Url: http://git.ipfire.org/gitweb/gitweb.cgi?a=commitdiff_plain;h=63bbaacf2319726666fd20fe26204285d400a990;p=thirdparty%2Fxfsprogs-dev.git xfs_repair: enable bigtime upgrade via repair Upgrade existing V5 filesystems to support large timestamps up to 2486. Signed-off-by: Darrick J. Wong Reviewed-by: Christoph Hellwig Reviewed-by: Brian Foster Signed-off-by: Eric Sandeen --- diff --git a/man/man8/xfs_admin.8 b/man/man8/xfs_admin.8 index eb9b6523d..ad28e0f68 100644 --- a/man/man8/xfs_admin.8 +++ b/man/man8/xfs_admin.8 @@ -143,6 +143,12 @@ This reduces mount time by speeding up metadata space reservation calculations. The filesystem cannot be downgraded after this feature is enabled. Once enabled, the filesystem will not be writable by older kernels. This feature was added to Linux 5.10. +.TP 0.4i +.B bigtime +Upgrade a filesystem to support larger timestamps up to the year 2486. +The filesystem cannot be downgraded after this feature is enabled. +Once enabled, the filesystem will not be mountable by older kernels. +This feature was added to Linux 5.10. .RE .TP .BI \-U " uuid" diff --git a/repair/globals.c b/repair/globals.c index 47d90bd32..506a4e728 100644 --- a/repair/globals.c +++ b/repair/globals.c @@ -49,6 +49,7 @@ int rt_spec; /* Realtime dev specified as option */ int convert_lazy_count; /* Convert lazy-count mode on/off */ int lazy_count; /* What to set if to if converting */ bool add_inobtcount; /* add inode btree counts to AGI */ +bool add_bigtime; /* add support for timestamps up to 2486 */ /* misc status variables */ diff --git a/repair/globals.h b/repair/globals.h index 5b6fe4d4f..929b82be3 100644 --- a/repair/globals.h +++ b/repair/globals.h @@ -90,6 +90,7 @@ extern int rt_spec; /* Realtime dev specified as option */ extern int convert_lazy_count; /* Convert lazy-count mode on/off */ extern int lazy_count; /* What to set if to if converting */ extern bool add_inobtcount; /* add inode btree counts to AGI */ +extern bool add_bigtime; /* add support for timestamps up to 2486 */ /* misc status variables */ diff --git a/repair/phase2.c b/repair/phase2.c index 96074a1df..cb9adf1d3 100644 --- a/repair/phase2.c +++ b/repair/phase2.c @@ -158,6 +158,27 @@ set_inobtcount( return true; } +static bool +set_bigtime( + struct xfs_mount *mp) +{ + if (!xfs_sb_version_hascrc(&mp->m_sb)) { + printf( + _("Large timestamp feature only supported on V5 filesystems.\n")); + exit(0); + } + + if (xfs_sb_version_hasbigtime(&mp->m_sb)) { + printf(_("Filesystem already supports large timestamps.\n")); + exit(0); + } + + printf(_("Adding large timestamp support to filesystem.\n")); + mp->m_sb.sb_features_incompat |= (XFS_SB_FEAT_INCOMPAT_NEEDSREPAIR | + XFS_SB_FEAT_INCOMPAT_BIGTIME); + return true; +} + /* Perform the user's requested upgrades on filesystem. */ static void upgrade_filesystem( @@ -169,6 +190,8 @@ upgrade_filesystem( if (add_inobtcount) dirty |= set_inobtcount(mp); + if (add_bigtime) + dirty |= set_bigtime(mp); if (no_modify || !dirty) return; diff --git a/repair/xfs_repair.c b/repair/xfs_repair.c index 8a9caf15c..38406eea4 100644 --- a/repair/xfs_repair.c +++ b/repair/xfs_repair.c @@ -66,12 +66,14 @@ static char *o_opts[] = { enum c_opt_nums { CONVERT_LAZY_COUNT = 0, CONVERT_INOBTCOUNT, + CONVERT_BIGTIME, C_MAX_OPTS, }; static char *c_opts[] = { [CONVERT_LAZY_COUNT] = "lazycount", [CONVERT_INOBTCOUNT] = "inobtcount", + [CONVERT_BIGTIME] = "bigtime", [C_MAX_OPTS] = NULL, }; @@ -313,6 +315,15 @@ process_args(int argc, char **argv) _("-c inobtcount only supports upgrades\n")); add_inobtcount = true; break; + case CONVERT_BIGTIME: + if (!val) + do_abort( + _("-c bigtime requires a parameter\n")); + if (strtol(val, NULL, 0) != 1) + do_abort( + _("-c bigtime only supports upgrades\n")); + add_bigtime = true; + break; default: unknown('c', val); break;