From: Tobias Brunner <tobias@strongswan.org>
Date: Fri, 7 Sep 2018 08:56:07 +0000 (+0200)
Subject: smp: Remove unreachable initializer
X-Git-Tag: 5.7.0rc1~14
X-Git-Url: http://git.ipfire.org/gitweb/gitweb.cgi?a=commitdiff_plain;h=648709b392e33120f8e9ef4f84447f3c1238ca7c;p=thirdparty%2Fstrongswan.git

smp: Remove unreachable initializer

Execution in this block will start with any of the case statements,
never with the initialization.
---

diff --git a/src/libcharon/plugins/smp/smp.c b/src/libcharon/plugins/smp/smp.c
index e7f6185847..29d3d2dada 100644
--- a/src/libcharon/plugins/smp/smp.c
+++ b/src/libcharon/plugins/smp/smp.c
@@ -76,7 +76,8 @@ static void write_id(xmlTextWriterPtr writer, char *element, identification_t *i
 	switch (id->get_type(id))
 	{
 		{
-			char *type = "";
+			char *type;
+
 			while (TRUE)
 			{
 				case ID_ANY: