From: dtucker@openbsd.org <dtucker@openbsd.org>
Date: Thu, 22 May 2025 12:14:19 +0000 (+0000)
Subject: upstream: Adjust debug message to prevent (unsigned) integer overflow.
X-Git-Url: http://git.ipfire.org/gitweb/gitweb.cgi?a=commitdiff_plain;h=6629eee21ca9d0a597a04dcac744a1ad882f912e;p=thirdparty%2Fopenssh-portable.git

upstream: Adjust debug message to prevent (unsigned) integer overflow.

Fixes Coverity CID 481110, ok djm@

OpenBSD-Commit-ID: 26178bf3b812707fb498ea85d076cadd1f2eb686
---

diff --git a/misc-agent.c b/misc-agent.c
index 712c42b82..cf9b0fa0c 100644
--- a/misc-agent.c
+++ b/misc-agent.c
@@ -1,4 +1,4 @@
-/* $OpenBSD: misc-agent.c,v 1.4 2025/05/22 03:41:10 dtucker Exp $ */
+/* $OpenBSD: misc-agent.c,v 1.5 2025/05/22 12:14:19 dtucker Exp $ */
 /*
  * Copyright (c) 2025 Damien Miller <djm@mindrot.org>
  *
@@ -59,7 +59,7 @@ hostname_hash(size_t len)
 
 	l = ssh_digest_bytes(SSH_DIGEST_SHA512);
 	if (len > 64) {
-		error_f("bad length %zu > max %zd", len, l - 1);
+		error_f("bad length %zu >= max %zd", len, l);
 		return NULL;
 	}
 	if (gethostname(hostname, sizeof(hostname)) == -1) {