From: Rico Tzschichholz <ricotz@ubuntu.com>
Date: Mon, 18 Mar 2024 11:19:00 +0000 (+0100)
Subject: parser: Turn `static const` declaration warning into an error
X-Git-Url: http://git.ipfire.org/gitweb/gitweb.cgi?a=commitdiff_plain;h=6d5191fdbc9d39bca33483d3f913775ac6509a11;p=thirdparty%2Fvala.git

parser: Turn `static const` declaration warning into an error
---

diff --git a/vala/valaparser.vala b/vala/valaparser.vala
index af1c4534a..0f2b1004d 100644
--- a/vala/valaparser.vala
+++ b/vala/valaparser.vala
@@ -3107,7 +3107,7 @@ public class Vala.Parser : CodeVisitor {
 	void parse_constant_declaration (Symbol parent, List<Attribute>? attrs) throws ParseError {
 		var begin = get_location ();
 		var access = parse_access_modifier ();
-		var flags = parse_member_declaration_modifiers ("constants", ModifierFlags.EXTERN | ModifierFlags.NEW | ModifierFlags.STATIC);
+		var flags = parse_member_declaration_modifiers ("constants", ModifierFlags.EXTERN | ModifierFlags.NEW);
 		expect (TokenType.CONST);
 		var type = parse_type (false, false);
 		string id = parse_identifier ();
@@ -3137,10 +3137,6 @@ public class Vala.Parser : CodeVisitor {
 		}
 		set_attributes (c, attrs);
 
-		if (ModifierFlags.STATIC in flags) {
-			Report.warning (c.source_reference, "the modifier `static' is not applicable to constants");
-		}
-
 		if (type.value_owned) {
 			Report.error (c.source_reference, "`owned' is not allowed on constants");
 		}