From: Ralf Wildenhues <Ralf.Wildenhues@gmx.de>
Date: Mon, 30 Aug 2010 20:42:11 +0000 (+0200)
Subject: tests: mark 'syntax of .la files' as XFAIL, expose failure.
X-Git-Tag: v2.4~66
X-Git-Url: http://git.ipfire.org/gitweb/gitweb.cgi?a=commitdiff_plain;h=730c1343a462ec5a1dde9a15c19459afaf85fdee;p=thirdparty%2Flibtool.git

tests: mark 'syntax of .la files' as XFAIL, expose failure.

* tests/lalib-syntax.at (syntax of .la files): Assert that the
string returned by lt_dlerror after a failure is non-NULL, so
the failure shows up on systems other than Solaris.  Mark test
as expected to fail.
Suggested by Bob Friesenhahn.

Signed-off-by: Ralf Wildenhues <Ralf.Wildenhues@gmx.de>
---

diff --git a/ChangeLog b/ChangeLog
index 60a2297c1..24d051b5a 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,12 @@
+2010-08-30  Ralf Wildenhues  <Ralf.Wildenhues@gmx.de>
+
+	tests: mark 'syntax of .la files' as XFAIL, expose failure.
+	* tests/lalib-syntax.at (syntax of .la files): Assert that the
+	string returned by lt_dlerror after a failure is non-NULL, so
+	the failure shows up on systems other than Solaris.  Mark test
+	as expected to fail.
+	Suggested by Bob Friesenhahn.
+
 2010-08-30  Eric Blake  <eblake@redhat.com>
 
 	Simplify recent configure quoting portability workaround.
diff --git a/tests/lalib-syntax.at b/tests/lalib-syntax.at
index c412d54cf..0f78ca8a2 100644
--- a/tests/lalib-syntax.at
+++ b/tests/lalib-syntax.at
@@ -1,6 +1,6 @@
 # lalib-syntax.at -- parsing .la files robustly  -*- Autotest -*-
 #
-#   Copyright (C) 2009 Free Software Foundation, Inc.
+#   Copyright (C) 2009, 2010 Free Software Foundation, Inc.
 #
 #   This file is part of GNU Libtool.
 #
@@ -25,9 +25,12 @@ AT_SETUP([syntax of .la files])
 AT_KEYWORDS([libtool])
 AT_KEYWORDS([libltdl])
 
+AT_XFAIL_IF([:]) dnl libltdl does not consistently return non-NULL lt_dlerror
+
 AT_DATA([main.c],
 [[#include <ltdl.h>
 #include <stdio.h>
+#include <assert.h>
 
 int
 main (int argc, char* argv[])
@@ -50,7 +53,9 @@ main (int argc, char* argv[])
     }
   else
     {
-      printf ("plugin failed to open: %s\n", lt_dlerror());
+      const char *error = lt_dlerror ();
+      assert (error != NULL);
+      printf ("plugin failed to open: %s\n", error);
       err = 1;
     }
   lt_dlexit ();