From: Allison Collins Date: Tue, 15 Sep 2020 19:59:37 +0000 (-0400) Subject: xfs: Remove xfs_trans_roll in xfs_attr_node_removename X-Git-Tag: v5.9.0-rc0~15 X-Git-Url: http://git.ipfire.org/gitweb/gitweb.cgi?a=commitdiff_plain;h=9086487f18b6633f99ecb7e6d32923738138865c;p=thirdparty%2Fxfsprogs-dev.git xfs: Remove xfs_trans_roll in xfs_attr_node_removename Source kernel commit: a237f2ddae4b79797fcb4290116acda38323da16 A transaction roll is not necessary immediately after setting the INCOMPLETE flag when removing a node xattr entry with remote value blocks. The remote block invalidation that immediately follows setting the flag is an in-core only change. The next step after that is to start unmapping the remote blocks from the attr fork, but the xattr remove transaction reservation includes reservation for full tree splits of the dabtree and bmap tree. The remote block unmap code will roll the transaction as extents are unmapped and freed. Signed-off-by: Allison Collins Reviewed-by: Brian Foster Reviewed-by: Darrick J. Wong Signed-off-by: Darrick J. Wong Acked-by: Dave Chinner Signed-off-by: Eric Sandeen --- diff --git a/libxfs/xfs_attr.c b/libxfs/xfs_attr.c index 5612fa32a..6089db83d 100644 --- a/libxfs/xfs_attr.c +++ b/libxfs/xfs_attr.c @@ -1142,10 +1142,6 @@ xfs_attr_node_removename( if (error) goto out; - error = xfs_trans_roll_inode(&args->trans, args->dp); - if (error) - goto out; - error = xfs_attr_rmtval_invalidate(args); if (error) return error;