From: Marek Schimara <Marek.Schimara@bull.net>
Date: Fri, 17 Jun 2016 08:04:46 +0000 (+0200)
Subject: src/rrd_xport.c: fix Coverity CIDs#13670,#13671 Resource leak
X-Git-Tag: v1.7.0~42^2~15
X-Git-Url: http://git.ipfire.org/gitweb/gitweb.cgi?a=commitdiff_plain;h=9710ef978bd904b6c049950ac8db62320d884dd3;p=thirdparty%2Frrdtool-1.x.git

src/rrd_xport.c: fix Coverity CIDs#13670,#13671 Resource leak

        CWE-404 / https://cwe.mitre.org/data/definitions/404.html
---

diff --git a/src/rrd_xport.c b/src/rrd_xport.c
index 388f7854..55735186 100644
--- a/src/rrd_xport.c
+++ b/src/rrd_xport.c
@@ -444,15 +444,17 @@ int rrd_graph_xport(image_desc_t *im) {
   default:
     break;
   }
+
+  /* free legend */
+  for (unsigned long j = 0; j < col_cnt; j++) {
+    free(legend_v[j]);
+  }
+  free(legend_v);
+  /* free data */
+  free(data);
+
   /* handle errors */
   if (r) {
-    /* free legend */
-    for (unsigned long j = 0; j < col_cnt; j++) {
-      free(legend_v[j]);
-    }
-    free(legend_v);
-    /* free data */
-    free(data);
     /* free the buffer */
     if (buffer.data) {free(buffer.data);}
     /* close the file */