From: Darrick J. Wong Date: Mon, 3 Feb 2025 22:40:39 +0000 (-0800) Subject: xfs_protofile: fix mode formatting error X-Git-Tag: v6.13.0~2 X-Git-Url: http://git.ipfire.org/gitweb/gitweb.cgi?a=commitdiff_plain;h=a9d781ec5505b9b96641f6130f043e45b7573307;p=thirdparty%2Fxfsprogs-dev.git xfs_protofile: fix mode formatting error The protofile parser expects the mode to be specified with three octal digits. Unfortunately, the generator doesn't get that right if the mode doesn't have any of bits 8-11 (aka no owner access privileges) set. Fixes: 6aace700b7b82d ("mkfs: add a utility to generate protofiles") Signed-off-by: Darrick J. Wong Reviewed-by: Christoph Hellwig --- diff --git a/mkfs/xfs_protofile.in b/mkfs/xfs_protofile.in index 9aee4336..356d3d80 100644 --- a/mkfs/xfs_protofile.in +++ b/mkfs/xfs_protofile.in @@ -45,7 +45,7 @@ def stat_to_str(statbuf): perms = stat.S_IMODE(statbuf.st_mode) - return '%s%s%s%o %d %d' % (type, suid, sgid, perms, statbuf.st_uid, \ + return '%s%s%s%03o %d %d' % (type, suid, sgid, perms, statbuf.st_uid, \ statbuf.st_gid) def stat_to_extra(statbuf, fullpath):