From: Bruce Ashfield Date: Thu, 24 Apr 2014 18:09:39 +0000 (-0400) Subject: kernel-yocto: quote kconfig mode check X-Git-Tag: lucaceresoli/bug-15201-perf-libtraceevent-missing~33741 X-Git-Url: http://git.ipfire.org/gitweb/gitweb.cgi?a=commitdiff_plain;h=aad19e4381a8a09c354e5899885997c5b4cd115b;p=thirdparty%2Fopenembedded%2Fopenembedded-core-contrib.git kernel-yocto: quote kconfig mode check We allow inheriting recipes to control the kconfig mode used by merge_config.sh via the KCONFIG_MODE variable. An error crept into the variable reference, and since it is not quoted, the true condition always runs. The result is that operations without an explicit kconfig mode cannot trigger allnoconfig for defconfig builds, which can result in some options being dropped from the final .config. Quoting the reference allows it to evaluate properly. Signed-off-by: Bruce Ashfield Signed-off-by: Saul Wold --- diff --git a/meta/classes/kernel-yocto.bbclass b/meta/classes/kernel-yocto.bbclass index 53bc6d443cd..6010dc94e02 100644 --- a/meta/classes/kernel-yocto.bbclass +++ b/meta/classes/kernel-yocto.bbclass @@ -241,7 +241,7 @@ do_kernel_configme() { echo "[INFO] doing kernel configme" export KMETA=${KMETA} - if [ -n ${KCONFIG_MODE} ]; then + if [ -n "${KCONFIG_MODE}" ]; then configmeflags=${KCONFIG_MODE} else # If a defconfig was passed, use =n as the baseline, which is achieved