From: Francis Dupont <fdupont@isc.org>
Date: Tue, 23 Oct 2018 15:52:32 +0000 (+0200)
Subject: [65-libyang-config-adaptor] A few cosmetics improvements
X-Git-Tag: 65-libyang-config-translator_base~1
X-Git-Url: http://git.ipfire.org/gitweb/gitweb.cgi?a=commitdiff_plain;h=b37b2a9d03649e2496d44a3537ea3312a9249a1a;p=thirdparty%2Fkea.git

[65-libyang-config-adaptor] A few cosmetics improvements
---

diff --git a/src/lib/yang/adaptor_config.cc b/src/lib/yang/adaptor_config.cc
index 729b982c29..653691b66e 100644
--- a/src/lib/yang/adaptor_config.cc
+++ b/src/lib/yang/adaptor_config.cc
@@ -37,7 +37,7 @@ AdaptorConfig::subnetsCollectID(ConstElementPtr subnets, SubnetIDSet& set) {
     }
 
     // If there are subnets defined, let's go over them one by one and
-    // colled subnet-ids used in them.
+    // collect subnet-ids used in them.
     for (ConstElementPtr subnet : subnets->listValue()) {
         if (!collectID(subnet, set)) {
             have_ids = false;
@@ -500,6 +500,7 @@ void
 AdaptorConfig::sanitizeDatabase(ConstElementPtr dhcp) {
     ConstElementPtr database = dhcp->get("hosts-database");
     if (!database) {
+        // nothing to do here.
         return;
     }
 
@@ -514,6 +515,7 @@ void
 AdaptorConfig::sanitizeRelaySuppliedOptions(ConstElementPtr dhcp) {
     ConstElementPtr options = dhcp->get("relay-supplied-options");
     if (!options || options->empty()) {
+        // nothing to do here.
         return;
     }
     ElementPtr mutable_dhcp = boost::const_pointer_cast<Element>(dhcp);
diff --git a/src/lib/yang/tests/.gitignore b/src/lib/yang/tests/.gitignore
new file mode 100644
index 0000000000..d6d1ec87a1
--- /dev/null
+++ b/src/lib/yang/tests/.gitignore
@@ -0,0 +1 @@
+/run_unittests
diff --git a/src/lib/yang/tests/Makefile.am b/src/lib/yang/tests/Makefile.am
index cd822beeb9..9297c9c597 100644
--- a/src/lib/yang/tests/Makefile.am
+++ b/src/lib/yang/tests/Makefile.am
@@ -18,11 +18,11 @@ TESTS =
 if HAVE_GTEST
 TESTS += run_unittests
 run_unittests_SOURCES  = adaptor_unittests.cc
-run_unittests_SOURCES += adaptor_config_unittests.cc
 run_unittests_SOURCES += adaptor_option_unittests.cc
 run_unittests_SOURCES += adaptor_pool_unittests.cc
 run_unittests_SOURCES += adaptor_host_unittests.cc
 run_unittests_SOURCES += adaptor_subnet_unittests.cc
+run_unittests_SOURCES += adaptor_config_unittests.cc
 run_unittests_SOURCES += sysrepo_setup.h
 run_unittests_SOURCES += translator_unittests.cc
 run_unittests_SOURCES += translator_control_socket_unittests.cc