From: Fabian.Kirsch@dlr.de Date: Wed, 13 Feb 2019 14:49:10 +0000 (+0000) Subject: libfdisk: sanity check, to prevent overlapping partitions from being partly reported... X-Git-Tag: v2.33.2~24 X-Git-Url: http://git.ipfire.org/gitweb/gitweb.cgi?a=commitdiff_plain;h=b419013aad1ece4bc16e2e84738daef66c95c535;p=thirdparty%2Futil-linux.git libfdisk: sanity check, to prevent overlapping partitions from being partly reported as free i noticed wrongly reported free space when looking with cfdisk on an USB drive prepared with the latest alpine *.iso[1]. Feel free to apply below patch, which fixed the issue for me. Greetings Fabian [1]: http://dl-cdn.alpinelinux.org/alpine/v3.9/releases/x86/alpine-extended-3.9.0-x86.iso Signed-off-by: Karel Zak --- diff --git a/libfdisk/src/table.c b/libfdisk/src/table.c index 4881db68e2..d551c8bd7b 100644 --- a/libfdisk/src/table.c +++ b/libfdisk/src/table.c @@ -575,7 +575,7 @@ done: * * Note that free space smaller than grain (see fdisk_get_grain_size()) is * ignored. - + * * Returns: 0 on success, otherwise, a corresponding error. */ int fdisk_get_freespaces(struct fdisk_context *cxt, struct fdisk_table **tb) @@ -632,7 +632,12 @@ int fdisk_get_freespaces(struct fdisk_context *cxt, struct fdisk_table **tb) /* add gaps between logical partitions */ if (fdisk_partition_is_container(pa)) rc = check_container_freespace(cxt, parts, *tb, pa); - last = fdisk_partition_get_end(pa); + + if (fdisk_partition_has_end(pa)) { + fdisk_sector_t pa_end = fdisk_partition_get_end(pa); + if (pa_end > last) + last = fdisk_partition_get_end(pa); + } nparts++; }