From: Darrick J. Wong Date: Fri, 20 Nov 2020 22:03:29 +0000 (-0500) Subject: xfs_repair: directly compare refcount records X-Git-Tag: xfsprogs-5.10-fixes_2020-12-06~19 X-Git-Url: http://git.ipfire.org/gitweb/gitweb.cgi?a=commitdiff_plain;h=c2c7b12424e0c1d691ccccbbaf18ed20c4249033;p=thirdparty%2Fxfsprogs-dev.git xfs_repair: directly compare refcount records Check that our observed refcount records have exact matches for what's in the ondisk refcount btree, since they're supposed to match exactly. Signed-off-by: Darrick J. Wong Reviewed-by: Christoph Hellwig Signed-off-by: Eric Sandeen --- diff --git a/repair/rmap.c b/repair/rmap.c index a4cc6a493..54451a7e2 100644 --- a/repair/rmap.c +++ b/repair/rmap.c @@ -1402,8 +1402,8 @@ _("Missing reference count record for (%u/%u) len %u count %u\n"), /* Compare each refcount observation against the btree's */ if (tmp.rc_startblock != rl_rec->rc_startblock || - tmp.rc_blockcount < rl_rec->rc_blockcount || - tmp.rc_refcount < rl_rec->rc_refcount) + tmp.rc_blockcount != rl_rec->rc_blockcount || + tmp.rc_refcount != rl_rec->rc_refcount) do_warn( _("Incorrect reference count: saw (%u/%u) len %u nlinks %u; should be (%u/%u) len %u nlinks %u\n"), agno, tmp.rc_startblock, tmp.rc_blockcount,