From: Marek Schimara <Marek.Schimara@bull.net>
Date: Thu, 16 Jun 2016 13:57:27 +0000 (+0200)
Subject: src/rrd_fetch_libdbi.c: fix Coverity CID#26513 Buffer not null terminated
X-Git-Tag: v1.7.0~42^2~25
X-Git-Url: http://git.ipfire.org/gitweb/gitweb.cgi?a=commitdiff_plain;h=c5ce2e1a16da1e191d108e1b38f40d44e375746a;p=thirdparty%2Frrdtool-1.x.git

src/rrd_fetch_libdbi.c: fix Coverity CID#26513 Buffer not null terminated

        CWE-170 / https://cwe.mitre.org/data/definitions/170.html
---

diff --git a/src/rrd_fetch_libdbi.c b/src/rrd_fetch_libdbi.c
index 46547614..b0ca2a66 100644
--- a/src/rrd_fetch_libdbi.c
+++ b/src/rrd_fetch_libdbi.c
@@ -435,7 +435,8 @@ rrd_fetch_fn_libdbi(
   separator=filename[3];
 
   /* copy filename for local modifications during parsing */
-  strncpy(filenameworkcopy,filename+5,sizeof(filenameworkcopy));
+  strncpy(filenameworkcopy,filename+5,sizeof(filenameworkcopy) - 1);
+  filenameworkcopy[sizeof(filenameworkcopy) - 1] = '\0';
 
   /* get the driver */
   table_help.dbdriver=tmpptr;