From: Otto Moerbeek <otto.moerbeek@open-xchange.com>
Date: Thu, 3 Jul 2025 08:05:08 +0000 (+0200)
Subject: Apply suggestions from code review from Miod
X-Git-Tag: rec-5.3.0-alpha2~11^2~2
X-Git-Url: http://git.ipfire.org/gitweb/gitweb.cgi?a=commitdiff_plain;h=d523fd752c0ebe286d3c4901a525bb8cabc1a214;p=thirdparty%2Fpdns.git

Apply suggestions from code review from Miod

Co-authored-by: Miod Vallat <miod.vallat@powerdns.com>
Signed-off-by: Otto Moerbeek <otto.moerbeek@open-xchange.com>
---

diff --git a/pdns/recursordist/mkpubsuffixcc b/pdns/recursordist/mkpubsuffixcc
index 9296d097f0..02c487c015 100755
--- a/pdns/recursordist/mkpubsuffixcc
+++ b/pdns/recursordist/mkpubsuffixcc
@@ -6,7 +6,9 @@ fi
 set -e
 echo "Downloading public suffix data and generating $1"
 temp=$(mktemp pubsuffixXXXXXX)
-curl -s -S https://publicsuffix.org/list/public_suffix_list.dat > $temp
+trap "rm -f $temp" 0 1 2 3 15
+set -e
+curl -o $temp -s -S https://publicsuffix.org/list/public_suffix_list.dat
 (echo "const char* g_pubsuffix[]={";
 	for a in $(grep -v "//" "$temp" | grep \\. | egrep "^[.0-9a-z-]*$")
 	do