From: Mike Brady <4265913+mikebrady@users.noreply.github.com>
Date: Tue, 16 Jul 2024 11:58:37 +0000 (+0100)
Subject: Remove the avcodec_free_context(&codec_context) -- seems to cause a double free.
X-Git-Tag: 4.3.5^2~50
X-Git-Url: http://git.ipfire.org/gitweb/gitweb.cgi?a=commitdiff_plain;h=e28c566a7db944ce349342525b2eec4ea3d981ad;p=thirdparty%2Fshairport-sync.git

Remove the avcodec_free_context(&codec_context) -- seems to cause a double free.
---

diff --git a/rtp.c b/rtp.c
index e44ff253..93e3fc84 100644
--- a/rtp.c
+++ b/rtp.c
@@ -2094,10 +2094,10 @@ void avcodec_alloc_context3_cleanup_handler(void *arg) {
   av_free(codec_context);
 }
 
-void avcodec_open2_cleanup_handler(void *arg) {
-  debug(3, "avcodec_open2_cleanup_handler");
-  AVCodecContext *codec_context = arg;
-  avcodec_free_context(&codec_context);
+void avcodec_open2_cleanup_handler(__attribute__((unused)) void *arg) {
+  debug(3, "avcodec_open2_cleanup_handler -- does nothing right now");
+  // AVCodecContext *codec_context = arg;
+  // avcodec_free_context(&codec_context);
 }
 
 void av_parser_init_cleanup_handler(void *arg) {