From: Alex Rousskov <rousskov@measurement-factory.com>
Date: Thu, 21 Feb 2019 21:56:48 +0000 (+0000)
Subject: Made Coverity happier after Bug 4864 fix (#371)
X-Git-Tag: M-staged-PR372~1
X-Git-Url: http://git.ipfire.org/gitweb/gitweb.cgi?a=commitdiff_plain;h=e7d3e24e3519df893626470101f8edda161f0146;p=thirdparty%2Fsquid.git

Made Coverity happier after Bug 4864 fix (#371)

... by addressing the following false-positive:
CID 1442832: Null pointer dereferences (FORWARD_NULL)

The Comm::IsConnOpen() test guarantees that connManager is not nil. An
explicit assert() might reduce bugs when this code is refactored.
---

diff --git a/src/FwdState.cc b/src/FwdState.cc
index 301da5a4a6..3c9cedada5 100644
--- a/src/FwdState.cc
+++ b/src/FwdState.cc
@@ -971,6 +971,7 @@ FwdState::usePinned()
     ++n_tries;
     request->flags.pinned = true;
 
+    assert(connManager);
     if (connManager->pinnedAuth())
         request->flags.auth = true;