From: Karel Zak <kzak@redhat.com>
Date: Tue, 22 Jun 2021 12:42:56 +0000 (+0200)
Subject: fsck: do not use atoi()
X-Git-Tag: v2.37.1~44
X-Git-Url: http://git.ipfire.org/gitweb/gitweb.cgi?a=commitdiff_plain;h=ee021a5f9e22521ac51a9d370b3b99f06ab8ab64;p=thirdparty%2Futil-linux.git

fsck: do not use atoi()

Addresses: https://github.com/karelzak/util-linux/issues/1358
Signed-off-by: Karel Zak <kzak@redhat.com>
---

diff --git a/disk-utils/fsck.c b/disk-utils/fsck.c
index b0f9ccb8d5..38a394de4e 100644
--- a/disk-utils/fsck.c
+++ b/disk-utils/fsck.c
@@ -1432,6 +1432,7 @@ static void parse_argv(int argc, char *argv[])
 	int     opts_for_fsck = 0;
 	struct sigaction	sa;
 	int	report_stats_fd = -1;
+	uint64_t num;
 
 	/*
 	 * Set up signal action
@@ -1604,8 +1605,8 @@ static void parse_argv(int argc, char *argv[])
 
 	if (getenv("FSCK_FORCE_ALL_PARALLEL"))
 		force_all_parallel++;
-	if ((tmp = getenv("FSCK_MAX_INST")))
-	    max_running = atoi(tmp);
+	if (ul_strtou64(getenv("FSCK_MAX_INST"), &num, 10) == 0 && num <= INT_MAX)
+		max_running = num;
 }
 
 int main(int argc, char *argv[])