From: pcarana <pc.moreno2099@gmail.com>
Date: Tue, 15 Dec 2020 00:37:17 +0000 (-0600)
Subject: Update default value of thread-pool.validation.max to 5
X-Git-Tag: v1.5.0~5
X-Git-Url: http://git.ipfire.org/gitweb/gitweb.cgi?a=commitdiff_plain;h=f863fb3b797802d075231b2ba23ed3cd93854bbb;p=thirdparty%2FFORT-validator.git

Update default value of thread-pool.validation.max to 5
---

diff --git a/docs/usage.md b/docs/usage.md
index 522180e5..fc2caf38 100644
--- a/docs/usage.md
+++ b/docs/usage.md
@@ -789,7 +789,7 @@ Once the client or the server terminates the session, the corresponding thread w
 
 - **Type:** Integer
 - **Availability:** `argv` and JSON
-- **Default:** 10
+- **Default:** 5
 - **Range:** 1--100
 
 Maximum number of threads that will be spawned at an internal thread pool in order to run validation cycles.
@@ -1026,9 +1026,9 @@ The configuration options are mostly the same as the ones from the `argv` interf
 			"<a href="#--thread-poolservermax">max</a>": 20
 		},
 		"validation": {
-			"<a href="#--thread-poolvalidationmax">max</a>": 10
+			"<a href="#--thread-poolvalidationmax">max</a>": 5
 		}
-	}
+	},
 
 	"<a href="#--asn1-decode-max-stack">asn1-decode-max-stack</a>": 4096,
 	"<a href="#--stale-repository-period">stale-repository-period</a>": 43200
diff --git a/examples/config.json b/examples/config.json
index 0909ea60..9c6cc432 100644
--- a/examples/config.json
+++ b/examples/config.json
@@ -107,6 +107,14 @@
     "roa": "/tmp/fort/roas.csv",
     "bgpsec": "/tmp/fort/bgpsec.csv"
   },
+  "thread-pool": {
+    "server": {
+      "max": 20
+    },
+    "validation": {
+      "max": 5
+    }
+  },
   "asn1-decode-max-stack": 4096,
   "stale-repository-period": 43200
 }
diff --git a/man/fort.8 b/man/fort.8
index 81c1c3a5..2e01b2a5 100644
--- a/man/fort.8
+++ b/man/fort.8
@@ -1154,7 +1154,7 @@ the location at \fI--tal\fR has 4 TAL files, only 2 TALs will be validated
 simultaneously while the rest waits in a queue until there's an available thread
 at the pool to attend them.
 .P
-By default, it has a value of \fI10\fR. Minimum allowed value: \fI1\fR,
+By default, it has a value of \fI5\fR. Minimum allowed value: \fI1\fR,
 maximum allowed value \fI100\fR.
 .RE
 
@@ -1367,7 +1367,7 @@ to a specific value:
       "max": 20
     },
     "validation": {
-      "max": 10
+      "max": 5
     }
   },
   "asn1-decode-max-stack": 4096,
diff --git a/src/config.c b/src/config.c
index 96b3d6a9..6e315eeb 100644
--- a/src/config.c
+++ b/src/config.c
@@ -1072,7 +1072,7 @@ set_default_values(void)
 	/* Common scenario is to connect 1 router or a couple of them */
 	rpki_config.thread_pool.server.max = 20;
 	/* Usually 5 TALs, let a few more available */
-	rpki_config.thread_pool.validation.max = 10;
+	rpki_config.thread_pool.validation.max = 5;
 
 	return 0;
 revert_init_locations: