From: Aleš Mrázek <ales.mrazek@nic.cz>
Date: Thu, 10 Oct 2024 12:36:28 +0000 (+0200)
Subject: lint: pylint and flake8 removed
X-Git-Tag: v5.7.5~3^2
X-Git-Url: http://git.ipfire.org/gitweb/gitweb.cgi?a=commitdiff_plain;h=refs%2Fenvironments%2Fdocs-develop-back-g3r3cl%2Fdeployments%2F6642;p=thirdparty%2Fknot-resolver.git

lint: pylint and flake8 removed

(cherry picked from commit d92fba4d12df38d50cc97daab4a4b81337bb57c5)
It now fails on 5.x pytest, too:
https://gitlab.nic.cz/knot/knot-resolver/-/jobs/1340121
---

diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
index 611ae7923..cbeddb9cf 100644
--- a/.gitlab-ci.yml
+++ b/.gitlab-ci.yml
@@ -325,12 +325,10 @@ trivial_checks: # aggregated to save some processing
     - ci/no_assert_check.sh
     - ci/deckard_commit_check.sh
 
-lint:other:
+lint:luacheck:
   <<: *sanity
   script:
     - meson build_ci_lint &>/dev/null
-    - ninja -C build_ci* pylint
-    - ninja -C build_ci* flake8
     - ninja -C build_ci* luacheck
 
 lint:pedantic:
diff --git a/meson.build b/meson.build
index bf9a6d850..0748e92db 100644
--- a/meson.build
+++ b/meson.build
@@ -278,8 +278,6 @@ install_data(
 message('--- lint dependencies ---')
 clangtidy = find_program('clang-tidy', required: false)
 luacheck = find_program('luacheck', required: false)
-flake8 = find_program('flake8', required: false)
-pylint_run = find_program('scripts/run-pylint.sh')
 message('-------------------------')
 
 if clangtidy.found()
@@ -306,22 +304,6 @@ if luacheck.found()
   )
 endif
 
-if flake8.found()
-  run_target(
-    'flake8',
-    command: [
-      flake8,
-      '--max-line-length=100',
-      meson.source_root() / 'tests' / 'pytests',
-    ],
-  )
-endif
-
-run_target(
-  'pylint',
-  command: pylint_run,
-)
-
 
 # Summary message
 # NOTE: ternary operator in format() not supported
diff --git a/scripts/run-pylint.sh b/scripts/run-pylint.sh
deleted file mode 100755
index 92413826c..000000000
--- a/scripts/run-pylint.sh
+++ /dev/null
@@ -1,12 +0,0 @@
-#!/bin/bash
-# SPDX-License-Identifier: GPL-3.0-or-later
-set -o errexit -o nounset
-
-cd "$(dirname ${0})/.."
-
-# Find Python modules and standalone Python scripts
-FILES=$(find ./tests/pytests \
-	-type d -exec test -e '{}/__init__.py' \; -print -prune -o \
-	-name '*.py' -print)
-
-python3 -m pylint -j 0 --rcfile ./tests/pytests/pylintrc ${FILES}
diff --git a/tests/pytests/pylintrc b/tests/pytests/pylintrc
deleted file mode 100644
index 5e2b50b56..000000000
--- a/tests/pytests/pylintrc
+++ /dev/null
@@ -1,32 +0,0 @@
-# SPDX-License-Identifier: GPL-3.0-or-later
-[MESSAGES CONTROL]
-
-disable=
-    missing-docstring,
-    too-few-public-methods,
-    too-many-arguments,
-    too-many-instance-attributes,
-    fixme,
-    unused-import,  # checked by flake8
-    line-too-long,  # checked by flake8
-    invalid-name,
-    broad-except,
-    global-statement,
-    no-else-return,
-    redefined-outer-name,  # commonly used with pytest fixtures
-    consider-using-with,
-    consider-using-f-string,
-
-
-[SIMILARITIES]
-min-similarity-lines=6
-ignore-comments=yes
-ignore-docstrings=yes
-ignore-imports=no
-
-[DESIGN]
-max-parents=10
-max-locals=20
-
-[TYPECHECK]
-ignored-modules=ssl