From: Vladimír Čunát <vladimir.cunat@nic.cz>
Date: Mon, 25 Mar 2024 10:23:37 +0000 (+0100)
Subject: manager, systemd: increase startup timeout for manager (again)
X-Git-Tag: v6.0.7~4^2
X-Git-Url: http://git.ipfire.org/gitweb/gitweb.cgi?a=commitdiff_plain;h=refs%2Fenvironments%2Fdocs-develop-impr-ktrcol%2Fdeployments%2F3578;p=thirdparty%2Fknot-resolver.git

manager, systemd: increase startup timeout for manager (again)

During the previous increase I didn't realize the comment added now.
---

diff --git a/NEWS b/NEWS
index e433fc8d8..6d108713e 100644
--- a/NEWS
+++ b/NEWS
@@ -6,7 +6,7 @@ Improvements
 - manager: clear the cache via management HTTP API (#876,!1491)
 - docs: documentation is now separated into user and developer parts (!1514)
 - daemon: ignore UDP requests from ports < 1024 (!1507)
-- manager: increase startup timeout for processes (!1518)
+- manager: increase startup timeout for processes (!1518, !1520)
 - local-data: increase default DB size to 2G on 64-bit platforms (!1518)
 
 Bugfixes
diff --git a/manager/knot_resolver_manager/kresd_controller/supervisord/supervisord.conf.j2 b/manager/knot_resolver_manager/kresd_controller/supervisord/supervisord.conf.j2
index c4dccecb8..dcbb645d9 100644
--- a/manager/knot_resolver_manager/kresd_controller/supervisord/supervisord.conf.j2
+++ b/manager/knot_resolver_manager/kresd_controller/supervisord/supervisord.conf.j2
@@ -47,7 +47,12 @@ stopsignal=SIGINT
 killasgroup=true
 autorestart=true
 autostart=true
-startsecs=10
+{# Note that during startup,
+   manager will signal being ready only after sequential startup of all kresd workers,
+   i.e. it might take lots of time currently, if the user configured very large rulesets (e.g. huge RPZ).
+   Let's permit it lots of time, assuming that useful work is being done.
+#}
+startsecs=600
 environment={{ manager.environment }},KRES_SUPRESS_LOG_PREFIX=true
 stdout_logfile=NONE
 stderr_logfile=NONE
diff --git a/systemd/knot-resolver.service.in b/systemd/knot-resolver.service.in
index c12775347..4cf544ad2 100644
--- a/systemd/knot-resolver.service.in
+++ b/systemd/knot-resolver.service.in
@@ -8,7 +8,7 @@ Wants=nss-lookup.target
 
 [Service]
 Type=notify
-TimeoutStartSec=10s
+TimeoutStartSec=600s
 ExecStart=@bin_dir@/knot-resolver --config=@etc_dir@/config.yaml
 Environment=KRES_LOGGING_TARGET=syslog
 ExecReload=@bin_dir@/kresctl --config=@etc_dir@/config.yaml reload