From: Michael Tremer <michael.tremer@ipfire.org>
Date: Wed, 25 Jun 2025 14:22:32 +0000 (+0100)
Subject: firewall.cgi: Remove some left-over debugging code
X-Git-Url: http://git.ipfire.org/gitweb/gitweb.cgi?a=commitdiff_plain;h=refs%2Fheads%2Fcore195;p=ipfire-2.x.git

firewall.cgi: Remove some left-over debugging code

This code prevented that any firewall rules could have been created due
to the WUI always assuming that there would be some error.

Fixes: #13860 - Error message when creating a firewall rule with a subnet for src
Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>
---

diff --git a/html/cgi-bin/firewall.cgi b/html/cgi-bin/firewall.cgi
index 855be095d..5f1eac09e 100644
--- a/html/cgi-bin/firewall.cgi
+++ b/html/cgi-bin/firewall.cgi
@@ -876,12 +876,6 @@ sub checkrule
 					$hint.=$Lang::tr{'fwdfw hint ip2'}." Source: $networkip1/$scidr Target: $networkip2/$tcidr<br>";
 				}
 		}else{
-			$errormessage .= $sip;
-			$errormessage .= $scidr;
-
-			$errormessage .= $tip;
-			$errormessage .= $tcidr;
-
 			if ( &General::IpInSubnet($networkip2,$sip,&General::iporsubtodec($scidr)) ){
 			$errormessage.=$Lang::tr{'fwdfw err samesub'} . $fwdfwsettings{'grp1'} .$fwdfwsettings{$fwdfwsettings{'grp1'}} . $fwdfwsettings{'grp2'} . $fwdfwsettings{$fwdfwsettings{'grp2'}};
 			}