From: Rico Tzschichholz <ricotz@ubuntu.com>
Date: Tue, 18 Feb 2020 15:20:42 +0000 (+0100)
Subject: vala: Don't process initializer of parameter if error is set
X-Git-Tag: 0.47.92~18
X-Git-Url: http://git.ipfire.org/gitweb/gitweb.cgi?a=commitdiff_plain;h=refs%2Fkeep-around%2F27fc5a83788c29a684241dd424dcb179e78b5e49;p=thirdparty%2Fvala.git

vala: Don't process initializer of parameter if error is set

This caused criticals like:

  vala_data_type_compatible: assertion 'self != NULL' failed
  vala_code_node_to_string: assertion 'self != NULL' failed
---

diff --git a/tests/Makefile.am b/tests/Makefile.am
index 69456f5bd..98c5e5faf 100644
--- a/tests/Makefile.am
+++ b/tests/Makefile.am
@@ -823,6 +823,7 @@ TESTS = \
 	semantic/objectcreation-non-public-constructor.test \
 	semantic/objectcreation-unsupported-type.test \
 	semantic/parameter-accessibility.test \
+	semantic/parameter-default-invalid.test \
 	semantic/parameter-default-type.test \
 	semantic/parameter-out-default.test \
 	semantic/parameter-params.test \
diff --git a/tests/semantic/parameter-default-invalid.test b/tests/semantic/parameter-default-invalid.test
new file mode 100644
index 000000000..987bc376c
--- /dev/null
+++ b/tests/semantic/parameter-default-invalid.test
@@ -0,0 +1,7 @@
+Invalid Code
+
+void foo (int bar = G) {
+}
+
+void main () {
+}
diff --git a/vala/valaparameter.vala b/vala/valaparameter.vala
index e447612d3..052b06ce8 100644
--- a/vala/valaparameter.vala
+++ b/vala/valaparameter.vala
@@ -176,7 +176,7 @@ public class Vala.Parameter : Variable {
 			}
 		}
 
-		if (initializer != null) {
+		if (initializer != null && !initializer.error) {
 			if (initializer is NullLiteral
 			    && !variable_type.nullable
 			    && direction != ParameterDirection.OUT) {